Reduce histogram metric cardinality for baseline resync#397
Merged
xiaoxichen merged 1 commit intoeBay:mainfrom Mar 11, 2026
Merged
Reduce histogram metric cardinality for baseline resync#397xiaoxichen merged 1 commit intoeBay:mainfrom
xiaoxichen merged 1 commit intoeBay:mainfrom
Conversation
xiaoxichen
force-pushed
the
reduce-histogram-cardinality
branch
from
1151615 to
38b2946
Compare
yuwmao
reviewed
Mar 11, 2026
Contributor
yuwmao
left a comment
yuwmao
left a comment
There was a problem hiding this comment.
LG in general, snapshot metrics will be removed once it completes, so it won't account too much.
xiaoxichen
force-pushed
the
reduce-histogram-cardinality
branch
2 times, most recently
from
0b06068 to
cc0ab15
Compare
Convert snapshot histogram metrics from full bucket distributions to sum/count publishing mode Changes: - Convert 4 snapshot histograms to publish_as_sum_count: - snp_dnr_blob_process_latency (donor) - snp_dnr_batch_process_latency (donor) - snp_rcvr_blob_process_time (receiver) - snp_rcvr_batch_process_time (receiver) - snapshot batch e2e remains as histogram - snp_dnr_batch_e2e_latency (donor) - Update 4 GC histogram comments for accuracy: - PercentileBuckets: 128 → 10 buckets (10% increments) - LinearUpto64Buckets: Clarify 17 buckets covering 0-64s Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
xiaoxichen
force-pushed
the
reduce-histogram-cardinality
branch
from
cc0ab15 to
394bafb
Compare
Collaborator
Author
yes , leaving the E2E as histogram. |
JacksonYao287
approved these changes
Mar 11, 2026
Collaborator
JacksonYao287
left a comment
JacksonYao287
left a comment
There was a problem hiding this comment.
GC metrics related changes looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert snapshot histogram metrics from full bucket distributions to sum/count publishing mode, reducing Prometheus cardinality by 82-93%.
Changes:
Convert 5 snapshot histograms to publish_as_sum_count:
Update 4 GC histogram comments for accuracy:
Full histogram data still collected locally for JSON API. Design doc: docs/plans/2026-03-11-reduce-histogram-cardinality-design.md